Build Simple node scenes in code

The method to instantiate a scene internally in 6d017d0 is clever, but
the real classes and internal classes create a circular dependency that
cause import errors. Since there are only a couple child nodes that are
significantly updated by the exported variables, just create the whole
scene in code.

There should be no functional changes besides dropping the internal
scenes. The only change is that the simple nodes can only be added as a
node type and not by the scene file. I don't think that will be missed.

https://phabricator.endlessm.com/T35494

Author: dbnicholson

addons/block_code/examples/pong_game/pong_game.tscn

@@ -841,7 +841,7 @@ position = Vector2(1984, 544)
 script = ExtResource("3_6jaq8")
 block_script = SubResource("Resource_6drva")
 
-[node name="SimpleScoring" type="CanvasLayer" parent="." groups=["hud"]]
+[node name="SimpleScoring" type="CanvasLayer" parent="."]
 follow_viewport_enabled = true
 script = ExtResource("13_tg3yk")
 

addons/block_code/simple_nodes/simple_character/_simple_character.gd

@@ -8,8 +8,7 @@ const Types = preload("res://addons/block_code/types/types.gd")
 @export var texture: Texture2D:
 	set = _set_texture
 
-@export var speed: Vector2 = Vector2(300, 300):
-	set = _set_speed
+@export var speed: Vector2 = Vector2(300, 300)
 
 const PLAYER_KEYS = {
 	"player_1":
@@ -28,6 +27,9 @@ const PLAYER_KEYS = {
 	}
 }
 
+var sprite: Sprite2D
+var collision: CollisionShape2D
+
 # Get the gravity from the project settings to be synced with RigidBody nodes.
 var gravity = ProjectSettings.get_setting("physics/2d/default_gravity")
 
@@ -36,18 +38,12 @@ var _jumping = false
 
 func _set_texture(new_texture):
 	texture = new_texture
+	_texture_updated()
 
-	if not is_node_ready():
-		return
-
-	$Sprite2D.texture = texture
-	var shape = RectangleShape2D.new()
-	shape.size = Vector2(100, 100) if texture == null else texture.get_size()
-	$CollisionShape2D.shape = shape
 
-
-func _set_speed(new_speed):
-	speed = new_speed
+func _texture_updated():
+	sprite.texture = texture
+	collision.shape.size = Vector2(100, 100) if texture == null else texture.get_size()
 
 
 ## Nodes in the "affected_by_gravity" group will receive gravity changes:
@@ -56,23 +52,16 @@ func on_gravity_changed(new_gravity):
 
 
 func _init():
-	if self.get_parent():
-		return
-
-	var node = preload("res://addons/block_code/simple_nodes/simple_character/_simple_character.tscn").instantiate() as Node
-	node.replace_by(self, true)
-	node.queue_free()
-	scene_file_path = ""
-
-
-func _ready():
 	add_to_group("affected_by_gravity")
-	simple_setup()
 
+	sprite = Sprite2D.new()
+	add_child(sprite)
+
+	collision = CollisionShape2D.new()
+	collision.shape = RectangleShape2D.new()
+	add_child(collision)
 
-func simple_setup():
-	_set_texture(texture)
-	_set_speed(speed)
+	_texture_updated()
 
 
 func get_custom_class():

addons/block_code/simple_nodes/simple_character/_simple_character.tscn

@@ -11,25 +11,48 @@ const Types = preload("res://addons/block_code/types/types.gd")
 @export var score_right: int:
 	set = _set_score_right
 
-@onready var _score_labels = {
-	"left": %PlayerLeftScore,
-	"right": %PlayerRightScore,
-}
+var _score_labels: Dictionary
 
 const _POSITIONS_FOR_PLAYER = {
 	"1": "left",
 	"2": "right",
 }
 
 
+func _create_score_label(player: String) -> Label:
+	var label := Label.new()
+
+	var x_pos: int
+	match player:
+		"left":
+			x_pos = 240
+		"right":
+			x_pos = 1200
+		_:
+			push_error('Unrecognized SimpleScoring player "%s"' % player)
+
+	label.set_size(Vector2(477, 1080))
+	label.set_position(Vector2(x_pos, 0))
+	label.pivot_offset = Vector2(240, 176)
+	label.size_flags_horizontal = Control.SizeFlags.SIZE_EXPAND_FILL
+	label.size_flags_vertical = Control.SizeFlags.SIZE_FILL
+	label.add_theme_font_size_override("font_size", 200)
+	label.text = "0"
+	label.horizontal_alignment = HorizontalAlignment.HORIZONTAL_ALIGNMENT_CENTER
+
+	return label
+
+
 func _init():
-	if self.get_parent():
-		return
+	add_to_group("hud")
+
+	var left_player_score := _create_score_label("left")
+	_score_labels["left"] = left_player_score
+	add_child(left_player_score)
 
-	var node = preload("res://addons/block_code/simple_nodes/simple_scoring/_simple_scoring.tscn").instantiate() as Node
-	node.replace_by(self, true)
-	node.queue_free()
-	scene_file_path = ""
+	var right_player_score := _create_score_label("right")
+	_score_labels["right"] = right_player_score
+	add_child(right_player_score)
 
 
 func get_custom_class():
@@ -38,16 +61,12 @@ func get_custom_class():
 
 func _set_score_left(new_score_left):
 	score_left = new_score_left
-	if not is_node_ready():
-		await ready
 	if score_left:
 		_update_label("left", score_left)
 
 
 func _set_score_right(new_score_right):
 	score_right = new_score_right
-	if not is_node_ready():
-		await ready
 	if score_right:
 		_update_label("right", score_right)