Skip to content

Commit 81a0e71

Browse files
gkalpakjosephperrott
authored andcommitted
ci: fix elements test on older browsers (angular#41324)
Some `elements` tests rely on `window.customElements` being available. On browsers where this was not present, the tests were skipped. This commit includes the `@webcomponents/custom-elements` polyfill in order to be able to run all `elements` tests on older browsers, which do not natively support Custom Elements. This, also, fixes the [saucelabs_ivy][1] and [saucelabs_view_engine][2] CI jobs (part of the `monitoring` workflow), which have been failing recently on IE 11 (probably due to the update to TS 4.2.3). [1]: https://circleci.com/gh/angular/angular/944291 [2]: https://circleci.com/gh/angular/angular/944289 PR Close angular#41324
1 parent a92a89b commit 81a0e71

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/elements/test/BUILD.bazel

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ filegroup(
3939
# do not sort
4040
srcs = [
4141
"@npm//:node_modules/core-js/client/core.js",
42+
# Required for browsers that do not natively support Custom Elements.
43+
"@npm//:node_modules/@webcomponents/custom-elements/custom-elements.min.js",
44+
# Required for ES5 code to work with a native Custom Elements implementation.
45+
# (See https://www.npmjs.com/package/@webcomponents/custom-elements#es5-vs-es2015.)
4246
":custom_elements_native_shim",
4347
"@npm//:node_modules/reflect-metadata/Reflect.js",
4448
"//packages/zone.js/bundles:zone.umd.js",

0 commit comments

Comments
 (0)