Fix: no-obj-calls false positive (fixes #12437) (#12467)

mysticatea · kaicataldo · commit 49faefbee3fc · 2019-10-24T15:55:12.000-04:00
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "debug": "^4.0.1",
     "doctrine": "^3.0.0",
     "eslint-scope": "^5.0.0",
-    "eslint-utils": "^1.4.2",
+    "eslint-utils": "^1.4.3",
     "eslint-visitor-keys": "^1.1.0",
     "espree": "^6.1.2",
     "esquery": "^1.0.1",
diff --git a/tests/lib/rules/no-obj-calls.js b/tests/lib/rules/no-obj-calls.js
@@ -61,6 +61,10 @@ ruleTester.run("no-obj-calls", rule, {
         {
             code: "function foo() { var Atomics = bar(); var baz = Atomics(5); }",
             globals: { Atomics: false }
+        },
+        {
+            code: "var construct = typeof Reflect !== \"undefined\" ? Reflect.construct : undefined; construct();",
+            globals: { Reflect: false }
         }
     ],
     invalid: [

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,10 @@ ruleTester.run("no-obj-calls", rule, {`
`61`	`61`	`{`
`62`	`62`	`code: "function foo() { var Atomics = bar(); var baz = Atomics(5); }",`
`63`	`63`	`globals: { Atomics: false }`
	`64`	`+ },`
	`65`	`+ {`
	`66`	`+ code: "var construct = typeof Reflect !== \"undefined\" ? Reflect.construct : undefined; construct();",`
	`67`	`+ globals: { Reflect: false }`
`64`	`68`	`}`
`65`	`69`	`],`
`66`	`70`	`invalid: [`