Have Wire1 pins autoset just like Wire

[ladyada]

Related area

I2C Peripheral

Hardware specification

Any hardware based on ESP32

Is your feature request related to a problem?

Wire is auto-setup for any ESP variant to the SDA/SCL pins
https://github.com/espressif/arduino-esp32/blob/master/variants/adafruit_qtpy_esp32s2/pins_arduino.h#L29
but SDA1/SCL1 pins do not do anything... it would be nice if setPins() was not required if these are #defined!
https://github.com/espressif/arduino-esp32/blob/master/variants/adafruit_qtpy_esp32s2/pins_arduino.h#L32

Describe the solution you'd like

we can submit a PR, but want to know whether it would be rejected before spending the time.

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

• I confirm I have checked existing list of Feature requests and Contribution Guide.

[SuGlider]

we can submit a PR, but want to know whether it would be rejected before spending the time.

I vote for moving forward with the PR.

but SDA1/SCL1 pins do not do anything... it would be nice if setPins() was not required if these are #defined!

YES!

https://github.com/espressif/arduino-esp32/blob/master/libraries/Wire/src/Wire.cpp#L78
https://github.com/espressif/arduino-esp32/blob/master/libraries/Wire/src/Wire.cpp#L95

I guess that this only means that when SoC is booted with Arduino, there is no initial pin setup for Wire1, but as suggested, a way to specify it for some boards that may label it, would be by testing SDA1/SCL1 defintion.

[VojtechBartoska]

We discussed it today with whole team and we don't see an issue about this. PR is very welcomed! @ladyada

[SuGlider]

@ladyada - Are you currently working on it?
I'm currently working in the Wire API to add a size_t Wire::set BufferSize(size_t) function and I can then move to the Wire1 pin autoset feature after finishing.
Please let me know.

[SuGlider]

@ladyada - Please evaluate and test PR #7034

[ladyada]

hi sorry i was totally halfway thru writing this PR and got completely swamped with a ton of folks visiting NYC in the last two weeks. will look now!

[ladyada]

reviewed and works great - it will close this issue when merged :)

[ladyada]

thank you @SuGlider for the great PR! 😅