From f3a7dbcdd117e1d057973005d9e43c495a3100de Mon Sep 17 00:00:00 2001 From: Luc Date: Wed, 8 Jun 2022 14:09:38 +0200 Subject: [PATCH] WireMaster example clarity - Created new temporary variable, stopping confusion with the reuse of "error". As Wire.requestFrom() doesn't return an error. - Added a cast to help clarify when and why bytes are being read --- libraries/Wire/examples/WireMaster/WireMaster.ino | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libraries/Wire/examples/WireMaster/WireMaster.ino b/libraries/Wire/examples/WireMaster/WireMaster.ino index a04998304b3..e3736bf9fcc 100644 --- a/libraries/Wire/examples/WireMaster/WireMaster.ino +++ b/libraries/Wire/examples/WireMaster/WireMaster.ino @@ -20,11 +20,11 @@ void loop() { Serial.printf("endTransmission: %u\n", error); //Read 16 bytes from the slave - error = Wire.requestFrom(I2C_DEV_ADDR, 16); - Serial.printf("requestFrom: %u\n", error); - if(error){ - uint8_t temp[error]; - Wire.readBytes(temp, error); - log_print_buf(temp, error); + uint8_t bytesReceived = Wire.requestFrom(I2C_DEV_ADDR, 16); + Serial.printf("requestFrom: %u\n", bytesReceived); + if((bool)bytesReceived){ //If received more than zero bytes + uint8_t temp[bytesReceived]; + Wire.readBytes(temp, bytesReceived); + log_print_buf(temp, bytesReceived); } }