Skip to content

Commit 237c453

Browse files
authored
fix: Feast create empty online table when FeatureView attribute online=False (#4666)
Signed-off-by: Theodor Mihalache <[email protected]>
1 parent 86573d2 commit 237c453

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

sdk/python/feast/infra/passthrough_provider.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,16 @@ def update_infra(
148148
):
149149
# Call update only if there is an online store
150150
if self.online_store:
151+
tables_to_keep_online = [
152+
fv
153+
for fv in tables_to_keep
154+
if not hasattr(fv, "online") or (hasattr(fv, "online") and fv.online)
155+
]
156+
151157
self.online_store.update(
152158
config=self.repo_config,
153159
tables_to_delete=tables_to_delete,
154-
tables_to_keep=tables_to_keep,
160+
tables_to_keep=tables_to_keep_online,
155161
entities_to_keep=entities_to_keep,
156162
entities_to_delete=entities_to_delete,
157163
partial=partial,

0 commit comments

Comments
 (0)