Skip to content

Bug: Actions with dropdown not displaying correctly in "..." dropdown of the Toolbar #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
QuaintMako opened this issue Oct 25, 2022 · 5 comments · Fixed by #17033
Closed

Bug: Actions with dropdown not displaying correctly in "..." dropdown of the Toolbar #10291

QuaintMako opened this issue Oct 25, 2022 · 5 comments · Fixed by #17033
Assignees
@yaira2
Labels
area - toolbar Features or bug reports relating to the toolbar

Comments

@QuaintMako
Copy link
Contributor

Description

When Files' window is small enough to force the toolbar actions to collapse into a "..." dropdown, some actions are not displaying correctly inside of it.

It seems to be specifically the actions leading to another dropdown : Set As Background, Extract etc...

Steps To Reproduce

In the case of an image :

  1. Reduce the size of the app window until the toolbar actions are collapsed into a "..." button.
  2. Select an image.
  3. Click on the "..." and observe the "Set as background" button.

Steps to fix

  • All the text describing the action should be displayed.
  • When an icon is present, the icon should be fully displayed.

Files Version

Version: 2.3.48.0 OS

Windows Version

W11 21H2 22000.1098

Relevant Assets/Logs

SetAsBackgroundToolbar
@QuaintMako QuaintMako added the bug label Oct 25, 2022
@QuaintMako
Copy link
Contributor Author

QuaintMako commented Oct 25, 2022 •
edited
Loading

We can see that the dropdown arrow is aligned on the left. It may be linked to it?

@Josh65-2201 Josh65-2201 moved this to 🆕 New in Files task board Oct 25, 2022
@yaira2 yaira2 changed the title Actions with dropdown not displaying correctly in "..." dropdown of the Toolbar Bug: Actions with dropdown not displaying correctly in "..." dropdown of the Toolbar Oct 25, 2022
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Oct 25, 2022
@0x5bfa 0x5bfa mentioned this issue Jun 24, 2024
Merged
4 tasks
@0x5bfa 0x5bfa mentioned this issue Jul 5, 2024
Closed
@0x5bfa
Copy link
Member

0x5bfa commented Jul 5, 2024

As we do for MenuFlyoutItem, we might want to create custom style with a custom dependnecy object for AppBarButton.

@yaira2 yaira2 removed the bug label Oct 7, 2024
@yaira2 yaira2 added the area - toolbar Features or bug reports relating to the toolbar label Dec 16, 2024
@yaira2
Copy link
Member

yaira2 commented Dec 16, 2024 •
edited
Loading

This will be resolved when we switch to our new toolbar control.

@yaira2 yaira2 self-assigned this Apr 9, 2025
@yaira2 yaira2 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Apr 9, 2025
@yaira2 yaira2 mentioned this issue Apr 9, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Apr 9, 2025
@yaira2
Copy link
Member

yaira2 commented Apr 9, 2025

@QuaintMako this issue will be resolved in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaira2 yaira2

Labels
area - toolbar Features or bug reports relating to the toolbar
Projects
Files task board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Fixed menu label for overflow items in the toolbar files-community/Files
3 participants
@yaira2 @0x5bfa @QuaintMako