Skip to content

Project is some update needs. (gradle.properties, AndroidMnifest.xml, google-services.json) #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masteage opened this issue Sep 1, 2020 · 2 comments
Labels
needs-info Need information for the developer type: question

Comments

@masteage
Copy link

masteage commented Sep 1, 2020

Please fill in the following fields:

  • macOS Catalina : 10.15.6
  • Android Studio : v4.0.1
  • Firebase C++ SDK version : v6.15.1
  • Firebase plugins in use : admob
  • Platform you are targeting Android (Simulator)

Please describe the issue here:

Please answer the following, if applicable:

  • Have you been able to reproduce this issue with just the Firebase C++ quickstarts (this GitHub project)?

    • -> YES
  • What's the issue repro rate? (eg 100%, 1/5 etc)

    • -> 100%
@chkuang-g
Copy link
Collaborator

Hi @masteage

Thank you for the suggestions.

I think the AndroidX/Jetifier change in gradle.properties make sense. However, all of the others are documented in readme.

I think you still need to follow instructions from readme for the sample Admob App Id and mock google-services.json anyway. Is there a particular reason you think those change are necessary?

Shawn

@chkuang-g chkuang-g added needs-info Need information for the developer type: question labels Sep 2, 2020
@chkuang-g
Copy link
Collaborator

BTW, currently we do not accept pull request in this repo.

@masteage masteage closed this as completed Sep 7, 2020
@firebase firebase locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-info Need information for the developer type: question
Projects
None yet
Development

No branches or pull requests

2 participants