-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Parametrize test_benchmarks.py
test by criterion benchmarks
#4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If someone has not done it yet, I would take it over. |
Hey @MacOS, please start working on it if you want. |
I would submit something next week, however, I am not mad if you do it. |
@gjkeller |
@cm-iwata |
Hi, sorry, I thought the latest update on the PR was that you were looking into why the CI was failing. Did you need help with anything? :o |
@roypat |
Currently,
test_benchmarks.py
contains a single test that runs all criterion benchmarks. With increasing number of benchmarks, we thus increase the duration of this test, and need to adjust its timeout. Instead, we want to parameterize the test by the list of criterion benchmarks we have in the repository. This means introducing a fixture that yields the benchmarks listed bycargo bench --all -- --list
individually. Then the test itself would only run the benchmark it is provided. This should also make it easier to see which benchmarks are failing.Originally posted by @pb8o in #4830 (comment)
The text was updated successfully, but these errors were encountered: