Skip to content

Commit 464cea5

Browse files
[camera_avfoundation] Tests backfilling - part 2 (#8796)
Backfills tests for the CameraPlugin class as part of flutter/flutter#119109 This PR adds tests for methods of `CameraPlugin` that only delegate to a `FLTCam` instance without any (or almost any for `startVideoRecording`) logic. In most circumstances, I would argue that those methods are so trivial that there is no point in testing them but for a plugin rewrite I believe those tests provide a little bit of value. The tests are also appropriately simple to write.
1 parent 2d3b24e commit 464cea5

File tree

3 files changed

+784
-0
lines changed

3 files changed

+784
-0
lines changed

packages/camera/camera_avfoundation/example/ios/Runner.xcodeproj/project.pbxproj

+4
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; };
5050
97DB234D2D566D0700CEFE66 /* CameraPreviewPauseTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 97DB234C2D566D0700CEFE66 /* CameraPreviewPauseTests.swift */; };
5151
E0CDBAC227CD9729002561D9 /* CameraTestUtils.m in Sources */ = {isa = PBXBuildFile; fileRef = E0CDBAC127CD9729002561D9 /* CameraTestUtils.m */; };
52+
E12C4FF62D68C69000515E70 /* CameraPluginDelegatingMethodTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E12C4FF52D68C69000515E70 /* CameraPluginDelegatingMethodTests.swift */; };
5253
E12C4FF82D68E85500515E70 /* MockFLTCameraPermissionManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = E12C4FF72D68E85500515E70 /* MockFLTCameraPermissionManager.swift */; };
5354
E1FFEAAD2D6C8DD700B14107 /* MockFLTCam.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1FFEAAC2D6C8DD700B14107 /* MockFLTCam.swift */; };
5455
E1FFEAAF2D6CDA8C00B14107 /* CameraPluginCreateCameraTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1FFEAAE2D6CDA8C00B14107 /* CameraPluginCreateCameraTests.swift */; };
@@ -145,6 +146,7 @@
145146
B61D98BBC8FB276D1C4A7BB2 /* Pods-RunnerTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.debug.xcconfig"; path = "Target Support Files/Pods-RunnerTests/Pods-RunnerTests.debug.xcconfig"; sourceTree = "<group>"; };
146147
E0CDBAC027CD9729002561D9 /* CameraTestUtils.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CameraTestUtils.h; sourceTree = "<group>"; };
147148
E0CDBAC127CD9729002561D9 /* CameraTestUtils.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CameraTestUtils.m; sourceTree = "<group>"; };
149+
E12C4FF52D68C69000515E70 /* CameraPluginDelegatingMethodTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CameraPluginDelegatingMethodTests.swift; sourceTree = "<group>"; };
148150
E12C4FF72D68E85500515E70 /* MockFLTCameraPermissionManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockFLTCameraPermissionManager.swift; sourceTree = "<group>"; };
149151
E1FFEAAC2D6C8DD700B14107 /* MockFLTCam.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockFLTCam.swift; sourceTree = "<group>"; };
150152
E1FFEAAE2D6CDA8C00B14107 /* CameraPluginCreateCameraTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CameraPluginCreateCameraTests.swift; sourceTree = "<group>"; };
@@ -201,6 +203,7 @@
201203
978D90B32D5F630300CD817E /* StreamingTests.swift */,
202204
97922B0C2D6380C300A9B4CF /* SampleBufferTests.swift */,
203205
978296CE2D5F744B0009BDD3 /* PhotoCaptureTests.swift */,
206+
E12C4FF52D68C69000515E70 /* CameraPluginDelegatingMethodTests.swift */,
204207
E1FFEAAE2D6CDA8C00B14107 /* CameraPluginCreateCameraTests.swift */,
205208
E1FFEAB02D6CDE5B00B14107 /* CameraPluginInitializeCameraTests.swift */,
206209
);
@@ -561,6 +564,7 @@
561564
97BD4A102D5CE13500F857D5 /* CameraSessionPresetsTests.swift in Sources */,
562565
7FD582272D57C020003B1200 /* MockAssetWriter.m in Sources */,
563566
979B3E022D5BA48F009BDE1A /* CameraOrientationTests.swift in Sources */,
567+
E12C4FF62D68C69000515E70 /* CameraPluginDelegatingMethodTests.swift in Sources */,
564568
977A25222D5A49EC00931E34 /* CameraFocusTests.swift in Sources */,
565569
978D90B42D5F630300CD817E /* StreamingTests.swift in Sources */,
566570
7F29EB412D281C7E00740257 /* MockCaptureSession.m in Sources */,

0 commit comments

Comments
 (0)