Skip to content

[video_player_android] Use handlesCropAndRotation to detect the SurfaceTexture Impeller backend #157198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camsim99 opened this issue Oct 18, 2024 · 1 comment · May be fixed by flutter/packages#9107
Open

[video_player_android] Use handlesCropAndRotation to detect the SurfaceTexture Impeller backend #157198

camsim99 opened this issue Oct 18, 2024 · 1 comment · May be fixed by flutter/packages#9107
Assignees
@camsim99
Labels
a: plugins Support for writing, building, and running plugin packages p: video_player The Video Player plugin P1 High-priority issues at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@camsim99
Copy link
Contributor

When handlesCropAndRotation implemented in flutter/engine#55434 makes it to stable, we should replace the logic implemented in flutter/packages#7846 to detect the SurfaceTexture Impeller backend with Build.VERSION.SDK_INT < 29 with it.
@camsim99 camsim99 added platform-android Android applications specifically p: video_player The Video Player plugin P2 Important issues not at the top of the work list a: plugins Support for writing, building, and running plugin packages team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Oct 18, 2024
@camsim99 camsim99 self-assigned this Oct 18, 2024
@camsim99 camsim99 added P1 High-priority issues at the top of the work list and removed P2 Important issues not at the top of the work list labels Feb 12, 2025
@camsim99
Copy link
Contributor Author

Given the impact this has had on camera_android_camerax, I want to pick this up this quarter to ensure we are properly covering corner cases for video_player.

@camsim99 camsim99 mentioned this issue Feb 28, 2025
Closed
11 tasks
@camsim99 camsim99 linked a pull request Apr 28, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camsim99 camsim99

Labels
a: plugins Support for writing, building, and running plugin packages p: video_player The Video Player plugin P1 High-priority issues at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
1 participant
@camsim99