Skip to content

Make fs instrumentation follow semantic conventions #14527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhiPrasad opened this issue Nov 28, 2024 · 1 comment
Open

Make fs instrumentation follow semantic conventions #14527

AbhiPrasad opened this issue Nov 28, 2024 · 1 comment

Comments

@AbhiPrasad
Copy link
Member

Description

See https://opentelemetry.io/docs/specs/semconv/attributes-registry/file/

span.setAttribute('path_argument', args[0]);
sets non namespaced attributes that don't follow conventions. We should see if we can set those as appropriate, and or contribute upstream to improve the conventions.

@AbhiPrasad AbhiPrasad added Package-Meta: OpenTelemetry Package: node Issues related to the Sentry Node SDK labels Nov 28, 2024
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Nov 29, 2024

It looks like we need to use https://opentelemetry.io/docs/specs/semconv/attributes-registry/error/

fs_error -> error.type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants