test: adapt to encode/django-rest-framework#5655

Author: joshuarli

tests/sentry/api/endpoints/test_organization_release_details.py

@@ -4,6 +4,7 @@
 
 import pytz
 from django.core.urlresolvers import reverse
+from rest_framework.exceptions import ErrorDetail
 
 from sentry.app import locks
 from sentry.constants import MAX_VERSION_LENGTH
@@ -589,7 +590,9 @@ def test_bad_commit_list(self):
             },
         )
         assert response.status_code == 400
-        assert response.data == {"commits": {"id": ["This field is required."]}}
+        assert response.data == {
+            "commits": {0: {"id": [ErrorDetail(string="This field is required.", code="required")]}}
+        }
 
 
 class ReleaseSerializerTest(unittest.TestCase):

tests/sentry/api/endpoints/test_project_releases.py

@@ -3,6 +3,7 @@
 import pytz
 from django.utils import timezone
 from django.core.urlresolvers import reverse
+from rest_framework.exceptions import ErrorDetail
 from exam import fixture
 
 from sentry.api.endpoints.project_releases import ReleaseWithVersionSerializer
@@ -593,8 +594,21 @@ def test_invalid_patch_type(self):
         )
 
         assert response.status_code == 400
-        assert dict(response.data) == {
-            "commits": {"patch_set": {"type": ["Commit patch_set type Z is not supported."]}}
+        assert response.data == {
+            "commits": {
+                0: {
+                    "patch_set": {
+                        0: {
+                            "type": [
+                                ErrorDetail(
+                                    string="Commit patch_set type Z is not supported.",
+                                    code="invalid",
+                                )
+                            ]
+                        }
+                    }
+                }
+            }
         }
 
 

tests/sentry/api/serializers/test_fields.py

@@ -1,7 +1,7 @@
 from rest_framework import serializers
+from rest_framework.exceptions import ErrorDetail
 
 from sentry.testutils import TestCase
-
 from sentry.api.serializers.rest_framework import ListField, ActorField
 from sentry.models import User, Team
 
@@ -31,14 +31,20 @@ def test_allow_null(self):
 
         serializer = DummySerializer(data=data)
         assert not serializer.is_valid()
-        assert serializer.errors == {"a_field": ["This field may not be null."]}
+        assert serializer.errors == {
+            "a_field": {0: [ErrorDetail(string="This field may not be null.", code="null")]}
+        }
 
     def test_child_validates(self):
         data = {"a_field": [{"b_field": "abcdefg"}]}
 
         serializer = DummySerializer(data=data)
         assert not serializer.is_valid()
-        assert serializer.errors == {"a_field": {"d_field": ["This field is required."]}}
+        assert serializer.errors == {
+            "a_field": {
+                0: {"d_field": [ErrorDetail(string="This field is required.", code="required")]}
+            }
+        }
 
 
 class TestActorField(TestCase):

tests/sentry/api/serializers/test_release.py

@@ -1,6 +1,8 @@
 from sentry.utils.compat.mock import patch
 from uuid import uuid4
 
+from rest_framework.exceptions import ErrorDetail
+
 from sentry import tagstore
 from sentry.api.endpoints.organization_releases import ReleaseSerializerWithProjects
 from sentry.api.serializers import serialize
@@ -464,7 +466,9 @@ def test_simple(self):
         serializer = ReleaseSerializerWithProjects(data=data)
 
         assert not serializer.is_valid()
-        assert serializer.errors == {"refs": ["This field may not be null."]}
+        assert serializer.errors == {
+            "refs": {0: [ErrorDetail("This field may not be null.", code="null")]}
+        }
 
         # test good refs
         data = {