Incorrect CSP configuration for gitlab integration

[Drevoed]

Version

0.14.16

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

The csp configuration does not allow custom adresses for gitlab integration.

And #8038 does not fix it. Because it only supports https://*.gitlab.com or https://gitlab.com.

e.g., what if user has a custom domain for self-hosted gitlab instance like this: https://mygitlab.acme.co?

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

[Byron]

Thanks a lot for reporting!

Maybe @Caleb-T-Owens can provide more context around the stage this feature is in, and what the plans are about it. Maybe supporting it would be easy if some URL validation is relaxed?

[krlvi]

Hi @Drevoed, sorry for the trouble. The app does not support custom domains yet but this is something that we plan to explore solving this soon. Here is the parent issue: #4714

[krlvi]

The next app release (0.14.19) will include a mechanism for adding custom CSP entries. I've also added documentation for how to configure this. If you wish to try it sooner, you can get the latest nightly build from here

Let me know if this helps.

[Drevoed]

Yes, thanks!