-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GitHub extension stopped reporting progress when cloning from the Start Page #2196
Comments
@jcansdale / @meaghanlewis looping you in based on the history of this repo 😄 I think @shana worked on the original implementation. I'm on the VS team and noticed this on the debugger. I think progress is currently broken in the clone api that the GitHub extension calls, so if you could validate that when IProgress passed to the clone API is non-null, that would help a lot. This is the file where a Code Container Provider is declared: VisualStudio/src/GitHub.StartPage/StartPagePackage.cs I'm happy to talk more if needed. //cc: @prnadago |
Hi @prasethu, I disabled this when working on a VS 2019 compatible version before the VS preview was out. VisualStudio/src/GitHub.TeamFoundation.14/Services/VSGitServices.cs Lines 82 to 98 in e98aa41
Now that I've got the VS 2019 assemblies to target, I should be able to reinstate it. 🤞 I'll keep you posted! |
Thanks @jcansdale ! There's a chance that this experience will ship in the next preview, so if you could make this work and build me a private VSIX I can try it on my side. |
In all recent versions of the GitHub extension, I've noticed that a clone from the Start Page does not show progress on the status bar of Visual Studio.
On debugging the Clone API call in Team Explorer I found that a null IProgress was being sent and hence progress cannot be reported.
We're planning to add this feature to the Start Window and this lack of progress will cause experience gaps.
The text was updated successfully, but these errors were encountered: