Merge pull request #19325 from joefarebrother/python-qual-loop-var-capture

joefarebrother · web-flow · commit 299b3f7af422 · 2025-04-29T13:49:09.000+01:00
Python: Tweak LoopVariableCapture for performance
diff --git a/python/ql/src/Variables/LoopVariableCapture/LoopVariableCaptureQuery.qll b/python/ql/src/Variables/LoopVariableCapture/LoopVariableCaptureQuery.qll
@@ -59,7 +59,7 @@ module EscapingCaptureFlowConfig implements DataFlow::ConfigSig {
   predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet cs) {
     isSink(node) and
     (
-      cs instanceof DataFlow::TupleElementContent or
+      cs.(DataFlow::TupleElementContent).getIndex() in [0 .. 10] or
       cs instanceof DataFlow::ListElementContent or
       cs instanceof DataFlow::SetElementContent or
       cs instanceof DataFlow::DictionaryElementAnyContent

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ module EscapingCaptureFlowConfig implements DataFlow::ConfigSig {`
`59`	`59`	`predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet cs) {`
`60`	`60`	`isSink(node) and`
`61`	`61`	`(`
`62`		`- cs instanceof DataFlow::TupleElementContent or`
	`62`	`+ cs.(DataFlow::TupleElementContent).getIndex() in [0 .. 10] or`
`63`	`63`	`cs instanceof DataFlow::ListElementContent or`
`64`	`64`	`cs instanceof DataFlow::SetElementContent or`
`65`	`65`	`cs instanceof DataFlow::DictionaryElementAnyContent`