Skip to content

Commit 382ebb1

Browse files
committed
C#: Update tests and expected output.
1 parent 5ba2894 commit 382ebb1

File tree

2 files changed

+22
-96
lines changed

2 files changed

+22
-96
lines changed

csharp/ql/test/query-tests/API Abuse/FormatInvalid/FormatInvalid.cs

+11-11
Original file line numberDiff line numberDiff line change
@@ -140,21 +140,21 @@ void CompositeFormatMethods()
140140
var format = CompositeFormat.Parse("}"); // $ Alert
141141

142142
// GOOD: Format is invalid and this flagged during parsing.
143-
String.Format<string>(null, format, "");
144-
String.Format<string, string>(null, format, "", "");
145-
String.Format<string, string, string>(null, format, "", "", "");
143+
String.Format<string>(null, format, ""); // $ Sink
144+
String.Format<string, string>(null, format, "", ""); // $ Sink
145+
String.Format<string, string, string>(null, format, "", "", ""); // $ Sink
146146

147-
sb.AppendFormat(null, format, "");
148-
sb.AppendFormat<string>(null, format, "");
149-
sb.AppendFormat<string, string>(null, format, "", "");
150-
sb.AppendFormat<string, string, string>(null, format, "", "", "");
147+
sb.AppendFormat(null, format, ""); // $ Sink
148+
sb.AppendFormat<string>(null, format, ""); // $ Sink
149+
sb.AppendFormat<string, string>(null, format, "", ""); // $ Sink
150+
sb.AppendFormat<string, string, string>(null, format, "", "", ""); // $ Sink
151151

152152

153153
var span = new Span<char>();
154-
span.TryWrite(null, format, out _);
155-
span.TryWrite<object>(null, format, out _, new object());
156-
span.TryWrite<object, object>(null, format, out _, new object(), new object());
157-
span.TryWrite<object, object, object>(null, format, out _, "", "", "");
154+
span.TryWrite(null, format, out _); // $ Sink
155+
span.TryWrite<object>(null, format, out _, new object()); // $ Sink
156+
span.TryWrite<object, object>(null, format, out _, new object(), new object()); // $ Sink
157+
span.TryWrite<object, object, object>(null, format, out _, "", "", ""); // $ Sink
158158
}
159159

160160
System.IO.StringWriter sw;

0 commit comments

Comments
 (0)