Skip to content

Commit edd18dc

Browse files
committed
C++: Address review comment
1 parent 7f90202 commit edd18dc

File tree

2 files changed

+14
-12
lines changed
  • cpp/ql/integration-tests/header-variant-tests

2 files changed

+14
-12
lines changed

cpp/ql/integration-tests/header-variant-tests/clang-pch/test.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33

44
def test(codeql, cpp):
55
os.mkdir("pch")
6+
extractor = f"{cpp.get_tool("extractor")}"
67
codeql.database.create(command=[
7-
f'"{cpp.get_tool("extractor")}" --mimic-clang -emit-pch -o pch/a.pch a.c',
8-
f'"{cpp.get_tool("extractor")}" --mimic-clang -include-pch pch/a.pch -Iextra_dummy_path b.c',
9-
f'"{cpp.get_tool("extractor")}" --mimic-clang -include pch/a -Iextra_dummy_path c.c',
10-
f'"{cpp.get_tool("extractor")}" --mimic-clang -emit-pch -o pch/d.pch d.c',
11-
f'"{cpp.get_tool("extractor")}" --mimic-clang -include-pch pch/d.pch e.c',
12-
f'"{cpp.get_tool("extractor")}" --mimic-clang -emit-pch -o pch/f.pch f.c',
13-
f'"{cpp.get_tool("extractor")}" --mimic-clang -include-pch pch/f.pch g.c',
14-
f'"{cpp.get_tool("extractor")}" --mimic-clang -emit-pch -o pch/h.pch h.c',
15-
f'"{cpp.get_tool("extractor")}" --mimic-clang -include-pch pch/h.pch i.c',
8+
f'"{extractor}" --mimic-clang -emit-pch -o pch/a.pch a.c',
9+
f'"{extractor}" --mimic-clang -include-pch pch/a.pch -Iextra_dummy_path b.c',
10+
f'"{extractor}" --mimic-clang -include pch/a -Iextra_dummy_path c.c',
11+
f'"{extractor}" --mimic-clang -emit-pch -o pch/d.pch d.c',
12+
f'"{extractor}" --mimic-clang -include-pch pch/d.pch e.c',
13+
f'"{extractor}" --mimic-clang -emit-pch -o pch/f.pch f.c',
14+
f'"{extractor}" --mimic-clang -include-pch pch/f.pch g.c',
15+
f'"{extractor}" --mimic-clang -emit-pch -o pch/h.pch h.c',
16+
f'"{extractor}" --mimic-clang -include-pch pch/h.pch i.c',
1617
])

cpp/ql/integration-tests/header-variant-tests/microsoft-pch/test.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33

44
def test(codeql, cpp):
55
os.mkdir("pch")
6+
extractor = f"{cpp.get_tool("extractor")}"
67
codeql.database.create(command=[
7-
f'"{cpp.get_tool("extractor")}" --mimic-cl /Yca.h /Fppch/a.pch a.c',
8-
f'"{cpp.get_tool("extractor")}" --mimic-cl /Yub.h /Fppch/a.pch b.c',
9-
f'"{cpp.get_tool("extractor")}" --mimic-cl /Yuc.h /Fppch/a.pch c.c',
8+
f'"{extractor}" --mimic-cl /Yca.h /Fppch/a.pch a.c',
9+
f'"{extractor}" --mimic-cl /Yub.h /Fppch/a.pch b.c',
10+
f'"{extractor}" --mimic-cl /Yuc.h /Fppch/a.pch c.c',
1011
])

0 commit comments

Comments
 (0)