Skip to content

installation with pip successfully happens despite missing git #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inashivb opened this issue Jun 29, 2023 · 1 comment
Closed

installation with pip successfully happens despite missing git #1602

inashivb opened this issue Jun 29, 2023 · 1 comment

Comments

@inashivb
Copy link

Hi, all! :)

I was installing GitPython on a fresh minimalistic docker image with pip3 which did not have git installed. Yet, the installation with pip happened successfully.

Successfully installed GitPython-3.1.31

I was only able to understand the issue when I tried to import something and there was error about bad git executable.

Is this the intended behavior?
Thank you for your time!

@Byron
Copy link
Member

Byron commented Jun 29, 2023

Yes, it's intended for GitPython to check for git at runtime, and not at install time. Arguments can be made for improving the messaging during installation, but I doubt it's going to happen - setup.py is messy enough as is 😅.
If you feel strongly about this, contributions are always welcome though.

@Byron Byron closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants