Skip to content

The tox flake8 test fails terribly #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jw opened this issue Dec 2, 2014 · 5 comments
Closed

The tox flake8 test fails terribly #214

jw opened this issue Dec 2, 2014 · 5 comments
Milestone

Comments

@jw
Copy link

jw commented Dec 2, 2014

I am working on this - it is a huge task...

@Byron
Copy link
Member

Byron commented Dec 3, 2014

Thanks.
Please note that the max-line-length is set to 120 characters - I have run autopep8 like so:

autopep8 -j 8 --max-line-length 120 --in-place --recursive --exclude "*gitdb*,*async*" *

Therefore most issues you see in flake8 can be fixed by adjusting the flake options accordingly.

@jw
Copy link
Author

jw commented Dec 5, 2014

Hey Byron,

I'm also updating for Python 3. You can see the progress on my fork.
Note that I'm still using the 79 chars per line rule, as specified by pep8.

I'll do a pull request in 2 to 3 days and I leave it up to you to decide.

Regards,
Jan

@jw
Copy link
Author

jw commented Dec 13, 2014

I am sorry Byron,

I have the feeling that the pygit2 forms a better and much cleaner solution to my problem; so I am going to end the further work on your project. Sorry for that.

If needed I can do a pull request, but for now tox fails miserably on my fork. The flake8 passes however.

Regards
Jan

@Byron
Copy link
Member

Byron commented Dec 15, 2014

Thanks for letting me know ! pygit2 is an excellent choice !
I will have a look at your fork to see if I can use some parts of it.

@Byron Byron added this to the v0.3.3 milestone Dec 15, 2014
@Byron
Copy link
Member

Byron commented Jan 4, 2015

Flake8 was setup to run successfully.

@Byron Byron closed this as completed Jan 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants