Skip to content

Environment values passed to Repo.clone_from() are not kept in the resulting repo #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpiotr opened this issue Sep 30, 2017 · 0 comments · Fixed by #677
Closed

Environment values passed to Repo.clone_from() are not kept in the resulting repo #676

bpiotr opened this issue Sep 30, 2017 · 0 comments · Fixed by #677

Comments

@bpiotr
Copy link
Contributor

bpiotr commented Sep 30, 2017

r = Repo.clone_from("[email protected]:bpiotr/whatever_repo.git", "/tmp/repo", env={"key": "value"})
r.git.environment()
{}

This is not what I expected when I called Repo.clone_from and documentation does not elaborate on the transient nature of the env here so IMHO this is a bug.

BTW it costed me quite a while to figure out that clone_from actually uses env but any subsequent operations on the result needs it to have it set again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants