Skip to content

Commit 24859fe

Browse files
sondr3lunny
authored andcommitted
Fix FOUC on Firefox (#1728)
Firefox users will experience a flash of unstyled content on loading various pages, this patch will fix this issue using Filament Groups loadCSS library to asynchronously load the CSS responsible for the FOUC. Will fix #1698. Signed-off-by: Sondre Nilsen <[email protected]>
1 parent 642f844 commit 24859fe

File tree

4 files changed

+17
-2
lines changed

4 files changed

+17
-2
lines changed

public/assets/librejs/librejs.html

+9
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,15 @@
3636
<td><a href="https://github.com/Ranks/emojify.js/archive/1.1.0.tar.gz">emojify-1.1.0.tar.gz</a></td>
3737
</tr>
3838
<tr>
39+
<td><a href="/js/libs/loadCSS.min.js">loadCSS.min.js</a></td>
40+
<td><a href="https://opensource.org/licenses/MIT">MIT License</a></td>
41+
<td><a href="https://github.com/filamentgroup/loadCSS/archive/v1.3.1.tar.gz">loadCSS-1.3.1.tar.gz</a></td>
42+
</tr>
43+
<tr>
44+
<td><a href="/js/libs/cssrelpreload.min.js">cssrelpreload.min.js</a></td>
45+
<td><a href="https://opensource.org/licenses/MIT">MIT License</a></td>
46+
<td><a href="https://github.com/filamentgroup/loadCSS/archive/v1.3.1.tar.gz">loadCSS-1.3.1.tar.gz</a></td>
47+
</tr>
3948
<td><a href="/plugins/dropzone-4.2.0/dropzone.js">dropzone.js</a></td>
4049
<td><a href="http://www.freebsd.org/copyright/freebsd-license.html">Expat</a></td>
4150
<td><a href="/plugins/dropzone-4.2.0/dropzone.js">dropzone.js</a></td>

public/js/libs/cssrelpreload.min.js

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/js/libs/loadCSS.min.js

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/base/head.tmpl

+4-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
{{end}}
2424

2525
<link rel="shortcut icon" href="{{AppSubUrl}}/img/favicon.png" />
26-
<link rel="stylesheet" href="{{AppSubUrl}}/assets/font-awesome-4.6.3/css/font-awesome.min.css">
26+
<link rel="preload" href="{{AppSubUrl}}/assets/font-awesome-4.6.3/css/font-awesome.min.css" as="style" onload="this.rel='stylesheet'">
27+
<noscript><link rel="stylesheet" href="{{AppSubUrl}}/assets/font-awesome-4.6.3/css/font-awesome.min.css"></noscript>
2728
<link rel="stylesheet" href="{{AppSubUrl}}/assets/octicons-4.3.0/octicons.min.css">
2829

2930
{{if .RequireSimpleMDE}}
@@ -53,7 +54,8 @@
5354
{{end}}
5455
<style class="list-search-style"></style>
5556

56-
<!-- Open Graph -->
57+
<script src="{{AppSubUrl}}/js/libs/loadCSS.min.js"></script>
58+
<script src="{{AppSubUrl}}/js/libs/cssrelpreload.min.js"></script>
5759
{{if .PageIsUserProfile}}
5860
<meta property="og:title" content="{{.Owner.Name}}" />
5961
<meta property="og:type" content="profile" />

0 commit comments

Comments
 (0)