Site admin could create repos even MAX_CREATION_LIMIT=0 (#4645) (#4650)

lunny · lafriks · commit eb8c611b1d50 · 2018-08-09T06:31:57.000+03:00
* site admin could create repos even MAX_CREATION_LIMIT=0

* Optimize if structure
diff --git a/models/repo.go b/models/repo.go
@@ -1407,7 +1407,7 @@ func createRepository(e *xorm.Session, doer, u *User, repo *Repository) (err err
 
 // CreateRepository creates a repository for the user/organization u.
 func CreateRepository(doer, u *User, opts CreateRepoOptions) (_ *Repository, err error) {
-	if !u.CanCreateRepo() {
+	if !doer.IsAdmin && !u.CanCreateRepo() {
 		return nil, ErrReachLimitOfRepo{u.MaxRepoCreation}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1407,7 +1407,7 @@ func createRepository(e xorm.Session, doer, u User, repo *Repository) (err err`
`1407`	`1407`
`1408`	`1408`	`// CreateRepository creates a repository for the user/organization u.`
`1409`	`1409`	`func CreateRepository(doer, u User, opts CreateRepoOptions) (_ Repository, err error) {`
`1410`		`- if !u.CanCreateRepo() {`
	`1410`	`+ if !doer.IsAdmin && !u.CanCreateRepo() {`
`1411`	`1411`	`return nil, ErrReachLimitOfRepo{u.MaxRepoCreation}`
`1412`	`1412`	`}`
`1413`	`1413`