Skip to content

PR acceptance blocked for PR creator #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasfantacuci opened this issue Feb 19, 2018 · 9 comments
Closed

PR acceptance blocked for PR creator #3543

lucasfantacuci opened this issue Feb 19, 2018 · 9 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.5.0

Comments

@lucasfantacuci
Copy link

lucasfantacuci commented Feb 19, 2018 •
edited
Loading

  • Gitea version (or commit ref): 1.2.3

Description

Our development team was thinking to use PR system to review our code, is there any feature to block the creator of the PR to accept it?

Screenshots

Image PR create
Image PR accept

On that example, the user administrator created de PR and accepted it.
@mbger
Copy link

mbger commented Feb 19, 2018

Right now, I don't think so. Probably only possible when #2794 is done. But correct me if I'm wrong.

@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 20, 2018
@lunny lunny added this to the 1.x.x milestone Feb 20, 2018
@thehowl
Copy link
Contributor

thehowl commented Feb 20, 2018

I'm pretty sure that you can set a collaborator's permission to 'Read', and that should grant them ability to make PRs & such, but not push directly. Although, of course, a repo admin / someone with write access would be needed to merge the PR.

@lunny lunny modified the milestones: 1.x.x, 1.5.0 May 11, 2018
@lunny
Copy link
Member

lunny commented May 11, 2018

resolved by #3689

@lunny lunny closed this as completed May 11, 2018
@cailyoung
Copy link

@lunny this is not resolved by #3689 - if the PR creator is on the whitelist they can merge. #2794 was abandoned. Is there any other issue in progress that would deliver this?

@lafriks
Copy link
Member

lafriks commented Apr 24, 2019

@cailyoung you can set that PR needs at least one approval

@lunny
Copy link
Member

lunny commented Apr 24, 2019

@lafriks 's idea is correct.

@cailyoung
Copy link

@lafriks @lunny

Apologies, we are not running 1.6.0 or newer. I will have a chat with the team here.

@cailyoung
Copy link

So #3748 fixes this - i.e. the PR creator cannot be an approver?

@lunny
Copy link
Member

lunny commented Apr 24, 2019

@cailyoung yes, one could not approve himself PR.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
6 participants
@lunny @lafriks @cailyoung @thehowl @mbger @lucasfantacuci