Skip to content

Add ability to review changes as in github #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iddm opened this issue Feb 25, 2018 · 5 comments
Closed

Add ability to review changes as in github #3580

iddm opened this issue Feb 25, 2018 · 5 comments
Assignees
@lafriks
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.6.0

Comments

@iddm
Copy link
Contributor

iddm commented Feb 25, 2018

It would be very nice to have review feature or at least an ability to comment changes in the pull request.
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 25, 2018
@krombel
Copy link

krombel commented Feb 26, 2018

@vityafx Might this be a duplicate of #124?

@iddm
Copy link
Contributor Author

iddm commented Feb 26, 2018 •
edited
Loading

Nope. The review feature is a bit more complicated than just comments. Have you ever done a review on github? :) So no, this is not a duplicate. I'll fix the title so it reflects the intentions correctly. Thanks for the noticing this issue.

@iddm iddm changed the title Add ability to comment changes as in github Add ability to review changes as in github Feb 26, 2018
@lafriks lafriks self-assigned this Feb 26, 2018
@lafriks
Copy link
Member

lafriks commented Feb 26, 2018

Depends on #2583

@lafriks lafriks added this to the 1.5.0 milestone Apr 2, 2018
@lafriks lafriks mentioned this issue Apr 2, 2018
Merged
23 tasks
@lafriks lafriks modified the milestones: 1.5.0, 1.6.0 Jun 5, 2018
@jonasfranz
Copy link
Member

Closed by #3748

@iddm
Copy link
Contributor Author

iddm commented Aug 6, 2018

Good work, thanks!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lafriks lafriks

Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
5 participants
@lunny @lafriks @iddm @jonasfranz @krombel