Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master@{1day}
Choose a base ref
...
head repository: golang/tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 14 commits
  • 8 files changed
  • 3 contributors

Commits on May 9, 2025

  1. internal/mcp/design: describe mcp-go delta 

    Describe the differences with mcp-go, and justify our choices.

Change-Id: Ib9b7ed87b8038f0b7cbc0eeffc5d7a7075eeae30
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671017
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    1ead56f View commit details
    Browse the repository at this point in the history

  2. internal/mcp: JSON Schema design 

    Describe how we use JSON Schema.

Change-Id: I488a09854333ba7280401e3bed5f50f83f481cd2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671215
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    c89ad19 View commit details
    Browse the repository at this point in the history

  3. internal/mcp: tool section of design 

    Describe our tool design. This is short because most of the interesting
part is in the JSON Schema section.

Change-Id: I017fca3055aef881285280a379e9f235bf95e75d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671355
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    d60d930 View commit details
    Browse the repository at this point in the history

  4. internal/mcp/design.md: client features 

    Change-Id: Iaed3461bcb35ca65c3118cafa0a5bbddfbd41ecc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671375
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    4160b77 View commit details
    Browse the repository at this point in the history

  5. internal/mcp/design.md: completions 

    Design for the completions feature.
Change-Id: Ia793091a10adb9c51472a9d3d4acdce8d6932536
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671376
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    8ee3f58 View commit details
    Browse the repository at this point in the history

  6. internal/mcp/design: add section on clients and servers 

    After much deliberation, revert back to the symmetrical many-to-one form
of the client APIs. Every time I tried to write the asymmetrical form, I
couldn't justify it. Furthermore, I think the names 'ClientSession' and
'ServerSession' significantly clarify the meaning.

Change-Id: I5c5e1eaf0d5de5ac7c98dab7aad9c0f31c3ff4e1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671177
Auto-Submit: Robert Findley <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
    @findleyr @gopherbot
    findleyr authored and gopherbot committed May 9, 2025
    Configuration menu
    Copy the full SHA
    ef35d72 View commit details
    Browse the repository at this point in the history

  7. internal/mcp/design: add a section on cancellation 

    Change-Id: If18a7d8efa37a6f34ae42f4d1896464800ebcdc7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671435
Reviewed-by: Jonathan Amsterdam <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
    @findleyr
    findleyr committed May 9, 2025
    Configuration menu
    Copy the full SHA
    b61ab33 View commit details
    Browse the repository at this point in the history

  8. internal/mcp: progress notifications 

    Change-Id: I3dad9326a88c14d08d62395f603862f71f887a75
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671475
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    b489159 View commit details
    Browse the repository at this point in the history

  9. internal/mcp/design.md: prompts and resources 

    Change-Id: I5663e14846e3a37bea6947a12fbe57117b07174b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671497
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    721ad8d View commit details
    Browse the repository at this point in the history

  10. internal/design: minor cleanup; add 'errors' and 'ping' sections 

    Perform some minor cleanup:
- Resolve semantic conflicts updating ServerConnection->ServerSession
- Use 'go' code blocks throughout

Also, add brief sections discussing error handling and 'ping/keepalive'.

Change-Id: I9ee888a7f0506ca380c2d4d4f9965a4c399aac19
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671495
Reviewed-by: Jonathan Amsterdam <[email protected]>
Commit-Queue: Robert Findley <[email protected]>
TryBot-Bypass: Robert Findley <[email protected]>
    @findleyr
    findleyr committed May 9, 2025
    Configuration menu
    Copy the full SHA
    d11c94a View commit details
    Browse the repository at this point in the history

  11. internal/mcp/design: remove the protocol package; update tools 

    Per discussion, remove the separate protocol package in favor of a
single mcp package. Update the tools section accordingly, and add more
discussion about the decision of the NewTool API.

Change-Id: Ifb259555ca9d493ce63bc4f71e5f2fa295bdf09c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671496
TryBot-Bypass: Robert Findley <[email protected]>
Commit-Queue: Robert Findley <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
    @findleyr
    findleyr committed May 9, 2025
    Configuration menu
    Copy the full SHA
    b303c1f View commit details
    Browse the repository at this point in the history

  12. internal/mcp/design: weave discussion of differences with mcp-go 

    Put discussion of mcp-go up front, and address differences in the
individual sections. I think this leads to easier reading for the user
who is concerned about our divergence in design.

Change-Id: Ifd21f6b9eb570ad4a325b8a8800b7868dac12205
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671556
TryBot-Bypass: Robert Findley <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Commit-Queue: Robert Findley <[email protected]>
    @findleyr
    findleyr committed May 9, 2025
    Configuration menu
    Copy the full SHA
    2cf2b2a View commit details
    Browse the repository at this point in the history

  13. gopls/internal/completion: apply modernizers 

    This CL replaces a lot of for loops with range loops.

Change-Id: I70e4742afe3dd223d953f01d4ca832f27d709541
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671395
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Madeline Kalil <[email protected]>
    @pjweinbgo
    pjweinbgo committed May 9, 2025
    Configuration menu
    Copy the full SHA
    ce6fe29 View commit details
    Browse the repository at this point in the history

  14. internal/mcp/design.md: minor changes 

    Fix typos and formatting, reword slightly.

Also, change names in the middleware section.

Change-Id: Ie86e5f633a07675ab188a8aaf70e51a48b0878bb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/671555
Reviewed-by: Robert Findley <[email protected]>
TryBot-Bypass: Jonathan Amsterdam <[email protected]>
    @jba
    jba committed May 9, 2025
    Configuration menu
    Copy the full SHA
    a240192 View commit details
    Browse the repository at this point in the history
Loading