Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/protobuf.dart
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a852ba4
Choose a base ref
...
head repository: google/protobuf.dart
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5e8f36b
Choose a head ref
  • 3 commits
  • 12 files changed
  • 2 contributors

Commits on Aug 15, 2023

  1. Rename a local variable to avoid proto field name conflicts, re-gener…

    …ate protos (#869)
    
    - Rename a local variable to avoid proto field name conflicts.
    
      This fixes an issue we're seeing with the latest version of
      `package:protoc_plugin` and the dartpad proto definitions.
    
    - Re-generate descriptor protos.
    
    - Update CI config to re-run publishing when labels change.
    devoncarew authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    41193fd View commit details
    Browse the repository at this point in the history
  2. Document why we add '$' prefix to result local in constructors (#870)

    We used to add a prefix before, but when I brought back the constructor
    arguments I didn't include it because (1) the previous prefix was `_` which
    caused lint errors (2) there were no tests or documentation on why the prefix
    was needed.
    
    Document it now so that it won't be removed again.
    
    (I couldn't add this in #869 as I didn't have push access to the PR's repo)
    osa1 authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    41d0156 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Add dart2wasm targets to benchmark builder (#806)

    This updates benchmark builder with two dart2wasm targets:
    
    - wasm: Default optimized build.
    - wasm-omit-checks: Optimized build with `--omit-checks`.
    
    README is updated with instructions to build and run new targets.
    osa1 authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5e8f36b View commit details
    Browse the repository at this point in the history
Loading