Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/python-fire
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: google/python-fire
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: z2017-03-21-fire-exit
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 2 contributors

Commits on Mar 22, 2017

  1. Exit with a status code if Fire encounters an error 

    Copybara generated commit for Python Fire.


PiperOrigin-RevId: 150818132
Change-Id: Ice3b2977fe0e89fa6472f0831e7475f3318943cf
Reviewed-on: https://team-review.git.corp.google.com/65029
Reviewed-by: David Bieber <[email protected]>
    @dbieber
    dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    32444b5 View commit details
    Browse the repository at this point in the history

  2. FireExit: ape argparse, flesh out test cases and get everything to pa… 

    …ss (#28)

* FireExit passing tests, ape argparse, doc update
1. Update documentation slightly
2. Get all tests to pass and note some additional edge cases
3. add helper method to capture all stdout and make it easier to write
   regexps for comparison
4. On proper `--help`, do the same thing as argparse and exit 0.

* Always include component trace + explicitly check type on exception
* Lint fixes and doc changes
* Move testutils to separate file
* Mock argv rather than pass in empty command
* Lint fixes
* Switch to raising exit code of 0 on show trace and show help
* Do not shadow component trace
    @jtratner @dbieber
    jtratner authored and dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    29baca7 View commit details
    Browse the repository at this point in the history

  3. assertRaisesFireExit, style fixes, do not expose FireExit publicly yet.

    @dbieber
    dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    e08a28a View commit details
    Browse the repository at this point in the history

  4. FireExit information in Fire docstring.

    @dbieber
    dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    1937496 View commit details
    Browse the repository at this point in the history

  5. FireExit docstrings

    @dbieber
    dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    95de757 View commit details
    Browse the repository at this point in the history

  6. Some fitzing with imports and docstrings to make the linters happy. 

    Copybara generated commit for Python Fire.


PiperOrigin-RevId: 150942368
Change-Id: I7ba73d5a9845d642f99ffeba6c953d8116830a33
Reviewed-on: https://team-review.git.corp.google.com/65058
Reviewed-by: David Bieber <[email protected]>
    @dbieber
    dbieber committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    60ebd77 View commit details
    Browse the repository at this point in the history
Loading