Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-auth-library-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.28.0
Choose a base ref
...
head repository: googleapis/google-auth-library-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.29.0
Choose a head ref
  • 13 commits
  • 18 files changed
  • 6 contributors

Commits on Oct 2, 2024

  1. chore(main): release 1.28.1-SNAPSHOT (#1522)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    08284f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix: make some enum fields final (#1526)

    * Make some enum fields final
    
    See go/bugpattern/ImmutableEnumChecker
    
    * One more field
    cushon authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8920155 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    b743b63 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. chore(deps): update dependency org.apache.maven.plugins:maven-surefir…

    …e-plugin to v3.5.1 (#1529)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | `3.5.0` -> `3.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.maven.plugins:maven-surefire-plugin/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.maven.plugins:maven-surefire-plugin/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.maven.plugins:maven-surefire-plugin/3.5.0/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.maven.plugins:maven-surefire-plugin/3.5.0/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/google-auth-library-java).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
    renovate-bot authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    60f76ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f154edb View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. feat: service sccount to service account impersonation to support uni…

    …verse domain (#1528)
    
    for context: b/340602527
    
    Changes in this pr:
    - Override `getUniverseDomain()` to grab source credentials’s universe domain (UD) by default. Always use source credentials UD, not explicit provided UD. (In current design, impersonated credentials may not have universe domain in the outer layer. relay on UD from source credential. This may change in future)
    - Fix `isDefaultUniverseDomain()` in `GoogleCredentials` to account for `getUniverseDomain()` overrides in child classes.
    - In refreshAccessToken(), use endpoint url pattern to account for TPC case.
      - note that I choose to bypass this refreshIfExpired step because it wrongly steps into code path meant only for OAuth2 token request (GDU flow). Filed #1534 to address this separately. But for GDU flow here, this refresh step is redundant because the SSJ will get re-generated at [initialize request](https://github.com/googleapis/google-auth-library-java/blob/a987ecd06fd25a0048cdb3da6d1df4d029d85d79/oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java#L558). Also skip this step for SA GDU with SSJ flow.
    - Throw IllegalStateException if UD is explicitly set (with parent class setter) and not matching source credential's UD
    
    - Fix toBuilder() to invoke super, and fix related issue with createScoped. (see #1489, #1428); Also fix equals() to compare super first.
    
    
    Not in this pr: 
    - idtoken and signBlob endpoint changes are out-of-scope for this pr, will raise separate pr for it.
    
    sa-to-sa impersonation is successfully E2E tested for TPC usage according to [go/prptst-testing-service-account-impersonation](http://goto.google.com/prptst-testing-service-account-impersonation).
    
    
    
    ---------
    
    Co-authored-by: Blake Li <[email protected]>
    zhumin8 and blakeli0 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c498ccf View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency org.apache.maven.plugins:maven-failsaf…

    …e-plugin to v3.5.1 (#1530)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [org.apache.maven.plugins:maven-failsafe-plugin](https://maven.apache.org/surefire/) | `3.5.0` -> `3.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.maven.plugins:maven-failsafe-plugin/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.maven.plugins:maven-failsafe-plugin/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.maven.plugins:maven-failsafe-plugin/3.5.0/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.maven.plugins:maven-failsafe-plugin/3.5.0/3.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/google-auth-library-java).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
    renovate-bot authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5af81ab View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    bf5a442 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e3d84c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5f8e91 View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency com.google.appengine:appengine-api-1.0…

    …-sdk to v2.0.31 (#1539)
    
    Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
    renovate-bot and gcf-merge-on-green[bot] authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9e03c34 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    9186122 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 1.29.0 (#1531)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d4a3763 View commit details
    Browse the repository at this point in the history
Loading