fix: include updates to properties from Google Auth lib #249
Conversation
| @@ -5,6 +5,6 @@ | |||
| # | |||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | |||
| # Then this file should have foo==1.14.0 | |||
| google-auth==2.13.0 | |||
| google-auth==2.14.0 | |||
There was a problem hiding this comment.
Updated. It looks like there are some kokoro dependencies which should be updated (they're currently pinned to version 2.11.0), but it looks like this is best updated through some automated process, as other dependencies will need to be updated as well with hash numbers
There was a problem hiding this comment.
I guess you are referring to https://github.com/googleapis/google-auth-library-python-oauthlib/blob/main/.kokoro/requirements.txt#L165?
@parthea do you know what is this for and if the google-auth version should be updated here manually?
There was a problem hiding this comment.
testing/constraints-3.6.txt should be testing the minimum versions of dependencies as it says at the top of the file. This is correct. The version in testing/constraints-3.6.txt should be google-auth==2.14.0.
The version of google-auth in .kokoro/requirements.txt is used for the release/docs publication and is not related to presubmits/testing. It will be updated automatically as we update dependencies for the release/docs infrastructure.
ScruffyProdigy
changed the title
| @@ -133,6 +133,8 @@ def credentials_from_session(session, client_config=None): | |||
| token_url=client_config.get("token_uri"), | |||
| client_id=client_config.get("client_id"), | |||
| client_secret=client_config.get("client_secret"), | |||
| token_info_url=client_config.get("token_info_url"), | |||
| scopes=session.scope, | |||
There was a problem hiding this comment.
why is this being added?
There was a problem hiding this comment.
This ends up passing the token_info_url from the login config to the credential class, so we can have an easier time doing introspection later. It also passes the scopes used to the credential class because it is useful for querying
There was a problem hiding this comment.
can you elaborate on "useful for querying"?
There was a problem hiding this comment.
If a user wants to know whether their credentials have the necessary permissions before trying to use them, they will need to know what scopes were used to create the credentials
There was a problem hiding this comment.
The token introspection endpoint is used to retrieve the account identifier for gcloud.
There was a problem hiding this comment.
Sorry I meant "why is this being added" for the scopes. I get why token_info_url is being added.
| @@ -5,6 +5,6 @@ | |||
| # | |||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | |||
| # Then this file should have foo==1.14.0 | |||
| google-auth==2.13.0 | |||
| google-auth==2.14.0 | |||
There was a problem hiding this comment.
I guess you are referring to https://github.com/googleapis/google-auth-library-python-oauthlib/blob/main/.kokoro/requirements.txt#L165?
@parthea do you know what is this for and if the google-auth version should be updated here manually?
| @@ -5,6 +5,6 @@ | |||
| # | |||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | |||
| # Then this file should have foo==1.14.0 | |||
| google-auth==2.13.0 | |||
| google-auth==2.14.0 | |||
sai-sunder-s
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕