Skip to content

Conversation

@vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Nov 6, 2024

This change does not require a major version bump because the classes removed were not being used: they were marked deprecated and had no run-time effect.

@vchudnov-g vchudnov-g requested a review from parthea November 6, 2024 23:40
@vchudnov-g vchudnov-g requested a review from a team as a code owner November 6, 2024 23:40
AttachNetworkEndpointsRegionNetworkEndpointGroupRequest,
AuditConfig,
AuditLogConfig,
AuthorizationLoggingOptions,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you update the PR body with a note that a major bump isn't required because the classes removed in this PR were not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@vchudnov-g vchudnov-g merged commit c0351dd into main Nov 7, 2024
19 checks passed
@vchudnov-g vchudnov-g deleted the thaw-diregapic branch November 7, 2024 16:20
@release-please release-please bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants