Skip to content

Commit 139254d

Browse files
committed
Fix test case
1 parent 45673db commit 139254d

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -807,8 +807,6 @@ public EnhancedBigtableStubSettings build() {
807807
Preconditions.checkArgument(
808808
getTransportChannelProvider() instanceof InstantiatingGrpcChannelProvider,
809809
"refreshingChannel only works with InstantiatingGrpcChannelProviders");
810-
Preconditions.checkArgument(
811-
appProfileId != null, "refreshingChannel only works when appProfileId is set");
812810
InstantiatingGrpcChannelProvider.Builder channelProviderBuilder =
813811
((InstantiatingGrpcChannelProvider) getTransportChannelProvider()).toBuilder();
814812
try {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BigtableDataClientFactoryTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import java.util.List;
4848
import java.util.concurrent.BlockingQueue;
4949
import java.util.concurrent.LinkedBlockingDeque;
50-
import java.util.concurrent.atomic.AtomicInteger;
5150
import org.junit.After;
5251
import org.junit.Before;
5352
import org.junit.Rule;
@@ -80,7 +79,6 @@ public class BigtableDataClientFactoryTest {
8079
private int port;
8180

8281
private final BlockingQueue<Attributes> attributes = new LinkedBlockingDeque<>();
83-
private final AtomicInteger terminationCount = new AtomicInteger();
8482

8583
@Before
8684
public void setUp() throws IOException {
@@ -100,12 +98,6 @@ public Attributes transportReady(Attributes transportAttrs) {
10098
attributes.add(transportAttrs);
10199
return super.transportReady(transportAttrs);
102100
}
103-
104-
@Override
105-
public void transportTerminated(Attributes transportAttrs) {
106-
terminationCount.incrementAndGet();
107-
super.transportTerminated(transportAttrs);
108-
}
109101
})
110102
.build();
111103

@@ -279,8 +271,6 @@ public void testCreateWithRefreshingChannel() throws Exception {
279271
}
280272
}
281273
assertThat(service.readRowsRequests).containsExactly(expectedRequests.toArray());
282-
factory.close();
283-
assertThat(terminationCount.get()).isEqualTo(poolSize);
284274
}
285275

286276
private static class FakeBigtableService extends BigtableGrpc.BigtableImplBase {

0 commit comments

Comments
 (0)