Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

SSLException isn't retryable #182

Closed
frankyn opened this issue Mar 13, 2020 · 0 comments · Fixed by #183
Closed

SSLException isn't retryable #182

frankyn opened this issue Mar 13, 2020 · 0 comments · Fixed by #183
Assignees
@frankyn
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Contributor

frankyn commented Mar 13, 2020

Hi,

Storage Java library users are failing on a retryable exception SocketException: Socket closed' errors which raised as a javax.net.ssl.SSLException. SSLException isn't considered retryable in BaseServiceException.java.

Are there any concerns with making this exception retryable along with:

  • SocketTimeoutException
  • SocketException
  • SSLHandshakeException

I'll send a PR to introduce this change for discussion.
@frankyn frankyn self-assigned this Mar 13, 2020
@frankyn frankyn added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 13, 2020
@frankyn frankyn mentioned this issue Mar 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@frankyn frankyn

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(182): retry SSLException googleapis/java-core
1 participant
@frankyn