feat: Allow customizing written log entries by exposing parameters via appender configuration #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
…logging-logback into losalex/fix-551
minherz
reviewed
Jan 10, 2022
src/main/java/com/google/cloud/logging/logback/LoggingAppender.java
Outdated
Show resolved
Hide resolved
| loggingOptions = LoggingOptions.getDefaultInstance(); | ||
| } else { | ||
| LoggingOptions.Builder builder = LoggingOptions.newBuilder(); | ||
| builder.setProjectId(projectId); |
There was a problem hiding this comment.
since the project id is already set via WriteOption there is no need to set it also using LoggingOptions.
I suggest to choice either method but not both.
There was a problem hiding this comment.
The projectId provided through setProjectId() overrides the one from credentials. If projectId was not set through setProjectId(), the one from credentials will be used
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
…logging-logback into losalex/fix-551
minherz
approved these changes
Jan 14, 2022
Comment on lines
+99
to
+101
| <!-- Optional: defaults to the project id obtained during authentication process. Project id is also used to construct resource name of the log entries --> | ||
| <logDestinationProjectId>String</logDestinationProjectId> | ||
|
|
There was a problem hiding this comment.
If this change is done by you, please undo it to avoid unnecessary PRs since the change to .readme-partials.yaml does the job.
If this change is submitted by Owlbot, please ignore this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables customizing logs destination by setting project/folder/organization/billing destinations (see more details under logName field).
Fixes #551 ☕️