Skip to content

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented May 19, 2020

Add four DLQ samples plus tests. Merge after a previous PR (#196) to set up samples testing is merged.

samples/
├── pom.xml
├── install-without-bom
│   ├── pom.xml
├── snapshot
│   ├── pom.xml
└── snippets
    ├── pom.xml
    └── src
        ├── main
        │   └── java
        │       └── pubsub
        │           ├── CreateSubscriptionWithDeadLetterPolicyExample.java
        │           ├── ReceiveMessagesWithDeliveryAttemptsExample.java
        │           ├── RemoveDeadLetterPolicyExample.java
        │           └── UpdateDeadLetterPolicyExample.java
        └── test
            └── java
                └── pubsub
                    └── DeadLetterQueueIT.java

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2020
@anguillanneuf anguillanneuf requested a review from hongalex May 19, 2020 20:17
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage     78.88%   78.88%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        150      150           
=========================================
  Hits           2145     2145           
  Misses          513      513           
  Partials         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e036e...44a205b. Read the comment docs.

@anguillanneuf anguillanneuf changed the title feat: add DLQ samples samples: add DLQ samples May 19, 2020
@anguillanneuf anguillanneuf merged commit 1dc651c into master May 20, 2020
@anguillanneuf anguillanneuf deleted the samples-dlq branch May 20, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants