Skip to content

Commit f434c1d

Browse files
committed
changed the host env variable
1 parent 8ad2163 commit f434c1d

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInOpenTelemetryMetricsProvider.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ final class BuiltInOpenTelemetryMetricsProvider {
6060
private BuiltInOpenTelemetryMetricsProvider() {}
6161

6262
OpenTelemetry getOrCreateOpenTelemetry(
63-
String projectId, @Nullable Credentials credentials, @Nullable String metricsHost) {
63+
String projectId, @Nullable Credentials credentials, @Nullable String monitoringHost) {
6464
try {
6565
if (this.openTelemetry == null) {
6666
SdkMeterProviderBuilder sdkMeterProviderBuilder = SdkMeterProvider.builder();
6767
BuiltInOpenTelemetryMetricsView.registerBuiltinMetrics(
68-
SpannerCloudMonitoringExporter.create(projectId, credentials, metricsHost),
68+
SpannerCloudMonitoringExporter.create(projectId, credentials, monitoringHost),
6969
sdkMeterProviderBuilder);
7070
this.openTelemetry =
7171
OpenTelemetrySdk.builder().setMeterProvider(sdkMeterProviderBuilder.build()).build();

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class SpannerCloudMonitoringExporter implements MetricExporter {
7171
private final String spannerProjectId;
7272

7373
static SpannerCloudMonitoringExporter create(
74-
String projectId, @Nullable Credentials credentials, @Nullable String metricsHost)
74+
String projectId, @Nullable Credentials credentials, @Nullable String monitoringHost)
7575
throws IOException {
7676
MetricServiceSettings.Builder settingsBuilder = MetricServiceSettings.newBuilder();
7777
CredentialsProvider credentialsProvider;
@@ -81,8 +81,8 @@ static SpannerCloudMonitoringExporter create(
8181
credentialsProvider = FixedCredentialsProvider.create(credentials);
8282
}
8383
settingsBuilder.setCredentialsProvider(credentialsProvider);
84-
if (metricsHost != null) {
85-
settingsBuilder.setEndpoint(metricsHost);
84+
if (monitoringHost != null) {
85+
settingsBuilder.setEndpoint(monitoringHost);
8686
}
8787

8888
org.threeten.bp.Duration timeout = Duration.ofMinutes(1);

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

+14-14
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public class SpannerOptions extends ServiceOptions<Spanner, SpannerOptions> {
164164
private final boolean enableBuiltInMetrics;
165165
private final boolean enableExtendedTracing;
166166
private final boolean enableEndToEndTracing;
167-
private final String metricsHost;
167+
private final String monitoringHost;
168168

169169
enum TracingFramework {
170170
OPEN_CENSUS,
@@ -673,7 +673,7 @@ protected SpannerOptions(Builder builder) {
673673
enableExtendedTracing = builder.enableExtendedTracing;
674674
enableBuiltInMetrics = builder.enableBuiltInMetrics;
675675
enableEndToEndTracing = builder.enableEndToEndTracing;
676-
metricsHost = builder.metricsHost;
676+
monitoringHost = builder.monitoringHost;
677677
}
678678

679679
/**
@@ -715,7 +715,7 @@ default boolean isEnableEndToEndTracing() {
715715
return false;
716716
}
717717

718-
default String getMetricsHost() {
718+
default String getMonitoringHost() {
719719
return null;
720720
}
721721
}
@@ -734,7 +734,7 @@ private static class SpannerEnvironmentImpl implements SpannerEnvironment {
734734
private static final String SPANNER_ENABLE_END_TO_END_TRACING =
735735
"SPANNER_ENABLE_END_TO_END_TRACING";
736736
private static final String SPANNER_DISABLE_BUILTIN_METRICS = "SPANNER_DISABLE_BUILTIN_METRICS";
737-
private static final String SPANNER_METRICS_HOST = "SPANNER_METRICS_HOST";
737+
private static final String SPANNER_MONITORING_HOST = "SPANNER_MONITORING_HOST";
738738

739739
private SpannerEnvironmentImpl() {}
740740

@@ -772,8 +772,8 @@ public boolean isEnableEndToEndTracing() {
772772
}
773773

774774
@Override
775-
public String getMetricsHost() {
776-
return System.getenv(SPANNER_METRICS_HOST);
775+
public String getMonitoringHost() {
776+
return System.getenv(SPANNER_MONITORING_HOST);
777777
}
778778
}
779779

@@ -840,7 +840,7 @@ public static class Builder
840840
private boolean enableExtendedTracing = SpannerOptions.environment.isEnableExtendedTracing();
841841
private boolean enableEndToEndTracing = SpannerOptions.environment.isEnableEndToEndTracing();
842842
private boolean enableBuiltInMetrics = SpannerOptions.environment.isEnableBuiltInMetrics();
843-
private String metricsHost = SpannerOptions.environment.getMetricsHost();
843+
private String monitoringHost = SpannerOptions.environment.getMonitoringHost();
844844

845845
private static String createCustomClientLibToken(String token) {
846846
return token + " " + ServiceOptions.getGoogApiClientLibName();
@@ -908,7 +908,7 @@ protected Builder() {
908908
this.enableExtendedTracing = options.enableExtendedTracing;
909909
this.enableBuiltInMetrics = options.enableBuiltInMetrics;
910910
this.enableEndToEndTracing = options.enableEndToEndTracing;
911-
this.metricsHost = options.metricsHost;
911+
this.monitoringHost = options.monitoringHost;
912912
}
913913

914914
@Override
@@ -1431,9 +1431,9 @@ public Builder setBuiltInMetricsEnabled(boolean enableBuiltInMetrics) {
14311431
return this;
14321432
}
14331433

1434-
/** Sets the metrics host to be used for Built-in client side metrics */
1435-
public Builder setMetricsHost(String metricsHost) {
1436-
this.metricsHost = metricsHost;
1434+
/** Sets the monitoring host to be used for Built-in client side metrics */
1435+
public Builder setMonitoringHost(String monitoringHost) {
1436+
this.monitoringHost = monitoringHost;
14371437
return this;
14381438
}
14391439

@@ -1747,7 +1747,7 @@ private ApiTracerFactory getDefaultApiTracerFactory() {
17471747
private ApiTracerFactory createMetricsApiTracerFactory() {
17481748
OpenTelemetry openTelemetry =
17491749
this.builtInOpenTelemetryMetricsProvider.getOrCreateOpenTelemetry(
1750-
this.getProjectId(), getCredentials(), this.metricsHost);
1750+
this.getProjectId(), getCredentials(), this.monitoringHost);
17511751

17521752
return openTelemetry != null
17531753
? new MetricsTracerFactory(
@@ -1775,8 +1775,8 @@ public boolean isEnableBuiltInMetrics() {
17751775
}
17761776

17771777
/** Returns the override metrics Host. */
1778-
String getMetricsHost() {
1779-
return metricsHost;
1778+
String getMonitoringHost() {
1779+
return monitoringHost;
17801780
}
17811781

17821782
@BetaApi

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -755,15 +755,15 @@ public void testEndToEndTracingEnablement() {
755755
}
756756

757757
@Test
758-
public void testMetricsHost() {
758+
public void testmonitoringHost() {
759759
String metricsEndpoint = "test-endpoint:443";
760-
assertNull(SpannerOptions.newBuilder().setProjectId("p").build().getMetricsHost());
760+
assertNull(SpannerOptions.newBuilder().setProjectId("p").build().getMonitoringHost());
761761
assertThat(
762762
SpannerOptions.newBuilder()
763763
.setProjectId("p")
764-
.setMetricsHost(metricsEndpoint)
764+
.setMonitoringHost(metricsEndpoint)
765765
.build()
766-
.getMetricsHost())
766+
.getMonitoringHost())
767767
.isEqualTo(metricsEndpoint);
768768
}
769769

0 commit comments

Comments
 (0)