Skip to content

fix: use a proper endpoint for DirectPath tests #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2022
Merged

fix: use a proper endpoint for DirectPath tests #2186

merged 3 commits into from
Dec 6, 2022

Conversation

ko3a4ok
Copy link
Contributor

@ko3a4ok ko3a4ok commented Dec 5, 2022

No description provided.

@ko3a4ok ko3a4ok requested a review from a team as a code owner December 5, 2022 23:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 5, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@rajatbhatta
Copy link
Contributor

Hi @ko3a4ok: Just had one question. Why are we setting the endpoint to wrenchworks-nonprod? Is it because this endpoint receives SpanFE releases early, and we would want to catch issues early on in the release cycle?

@ko3a4ok
Copy link
Contributor Author

ko3a4ok commented Dec 6, 2022

Hi @ko3a4ok: Just had one question. Why are we setting the endpoint to wrenchworks-nonprod? Is it because this endpoint receives SpanFE releases early, and we would want to catch issues early on in the release cycle?

@rajatbhatta this is a canary endpoint for prod SpanFE servers. It receives the binary release earlier than the rest of prod Spanner frontend servers. We're using a different set of probers to detect any regressions for DirectPath on the server side. This endpoint(wrenchworks-nonprod) will help us to detect regressions on the client side(Spanner lib, or grpc, rls, xds etc). So, technically, we can use any Spanner endpoint. But spanner.googleapis.com isn't available publicly with DirectPath, but wrenchworks-nonprod.googleapis.com has been setup and tested with DirectPath for a while

@rajatbhatta
Copy link
Contributor

Hi @ko3a4ok: Just had one question. Why are we setting the endpoint to wrenchworks-nonprod? Is it because this endpoint receives SpanFE releases early, and we would want to catch issues early on in the release cycle?

@rajatbhatta this is a canary endpoint for prod SpanFE servers. It receives the binary release earlier than the rest of prod Spanner frontend servers. We're using a different set of probers to detect any regressions for DirectPath on the server side. This endpoint(wrenchworks-nonprod) will help us to detect regressions on the client side(Spanner lib, or grpc, rls, xds etc). So, technically, we can use any Spanner endpoint. But spanner.googleapis.com isn't available publicly with DirectPath, but wrenchworks-nonprod.googleapis.com has been setup and tested with DirectPath for a while

Thanks for clarifying! LGTM.

@rajatbhatta rajatbhatta merged commit 4d74a0d into googleapis:main Dec 6, 2022
@release-please release-please bot mentioned this pull request Dec 6, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2022
@release-please
chore(main): release 6.34.0 (#2169)
6c3e3cc 
🤖 I have created a release *beep* *boop*
---


## [6.34.0](https://togithub.com/googleapis/java-spanner/compare/v6.33.0...v6.34.0) (2022-12-12)


### Features

* Setting up 6.33.x branch ([#2184](https://togithub.com/googleapis/java-spanner/issues/2184)) ([e237a21](https://togithub.com/googleapis/java-spanner/commit/e237a213cf5cb5edc338ca4e5f8ad5dd0593d2d1))


### Bug Fixes

* Remove the statement of session number limits ([#1928](https://togithub.com/googleapis/java-spanner/issues/1928)) ([ddd0625](https://togithub.com/googleapis/java-spanner/commit/ddd062527674659ca2ea73e079bca4dee62ca67f)), closes [#1927](https://togithub.com/googleapis/java-spanner/issues/1927)
* Update samples/snippets pom.xml configuration to avoid fat jar ([#2100](https://togithub.com/googleapis/java-spanner/issues/2100)) ([19058b4](https://togithub.com/googleapis/java-spanner/commit/19058b4cd324ce33e8dd52447bde2486c87d4754))
* Use a proper endpoint for DirectPath tests ([#2186](https://togithub.com/googleapis/java-spanner/issues/2186)) ([4d74a0d](https://togithub.com/googleapis/java-spanner/commit/4d74a0d8ae48e190c126ab4047b81cca117f4de1))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#2171](https://togithub.com/googleapis/java-spanner/issues/2171)) ([f348780](https://togithub.com/googleapis/java-spanner/commit/f3487805fe5f976596e94047c3796bc623eeae95))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#2145](https://togithub.com/googleapis/java-spanner/issues/2145)) ([dcdd2c3](https://togithub.com/googleapis/java-spanner/commit/dcdd2c3b684e38892fac0abbdf06081e9c7d83b2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ko3a4ok @rajatbhatta @yoshi-kokoro