-
Notifications
You must be signed in to change notification settings - Fork 131
feat: enable hermetic library generation #3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
approved these changes
Jun 27, 2024
rahul2393
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to enable multi-version support in hand-written libraries. More context and details in this doc.
This PR adds two workflows and their scripts:
update_generation_config
which updatesgeneration_config.yaml
(added in this PR) to contain the latestgoogleapis_committish
(source of truth of library generation) as well as other dependencies such asgapic_generator_version
. This job runs nightly and creates a PR that modifies the config yaml.hermetic_library_generation
which readsgeneration_config.yaml
and pushes a new commit to any PR whose latest commit affectsgeneration_config.yaml
(e.g. the nightly PR created byupdate_generation_config
). It essentially translates changes in the config yaml to changes in the source code (of the generated part). This workflow will be a required check.As an example of how they work in practice:
update_generation_config
creates a PR that updatesgeneration_config.yaml
with the latest dependencies and googleapis committishhermetic_library_generation
is triggered by this PR and generates the corresponding code changes. A new commit with the code changes is added to the PR. This step may occur for any PR affectinggeneration_config.yaml
.Follow ups
CLOUD_JAVA_BOT_TOKEN
to repository for the hermetic generation workflow to work. We confirmed it works in our fork (job link).