Skip to content

Commit b9f0c70

Browse files
committed
pr comments
1 parent a7eb3b5 commit b9f0c70

File tree

1 file changed

+5
-19
lines changed

1 file changed

+5
-19
lines changed

google-cloud-storage/src/main/java/com/google/cloud/storage/transfermanager/TransferManagerImpl.java

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
import com.google.cloud.storage.BlobId;
2626
import com.google.cloud.storage.BlobInfo;
2727
import com.google.cloud.storage.BlobWriteSessionConfigs;
28-
import com.google.cloud.storage.GrpcStorageOptions;
29-
import com.google.cloud.storage.HttpStorageOptions;
3028
import com.google.cloud.storage.ParallelCompositeUploadBlobWriteSessionConfig;
3129
import com.google.cloud.storage.ParallelCompositeUploadBlobWriteSessionConfig.ExecutorSupplier;
3230
import com.google.cloud.storage.Storage;
@@ -82,23 +80,11 @@ final class TransferManagerImpl implements TransferManager {
8280
.build();
8381
}
8482
// Create the blobWriteSessionConfig for ParallelCompositeUpload
85-
ParallelCompositeUploadBlobWriteSessionConfig pcuConfig =
86-
BlobWriteSessionConfigs.parallelCompositeUpload()
87-
.withExecutorSupplier(ExecutorSupplier.useExecutor(executor));
88-
if (storageOptions instanceof GrpcStorageOptions
89-
&& transferManagerConfig.isAllowParallelCompositeUpload()) {
90-
storageOptions =
91-
((GrpcStorageOptions) storageOptions)
92-
.toBuilder()
93-
.setBlobWriteSessionConfig(pcuConfig)
94-
.build();
95-
} else if (storageOptions instanceof HttpStorageOptions
96-
&& transferManagerConfig.isAllowParallelCompositeUpload()) {
97-
storageOptions =
98-
((HttpStorageOptions) storageOptions)
99-
.toBuilder()
100-
.setBlobWriteSessionConfig(pcuConfig)
101-
.build();
83+
if (transferManagerConfig.isAllowParallelCompositeUpload()) {
84+
ParallelCompositeUploadBlobWriteSessionConfig pcuConfig =
85+
BlobWriteSessionConfigs.parallelCompositeUpload()
86+
.withExecutorSupplier(ExecutorSupplier.useExecutor(executor));
87+
storageOptions = storageOptions.toBuilder().setBlobWriteSessionConfig(pcuConfig).build();
10288
}
10389
pcuQueue = new ArrayDeque<>();
10490
this.storage = storageOptions.getService();

0 commit comments

Comments
 (0)