docs(samples): add storage_grpc_quickstart samples #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
size: s
BenWhitehead
force-pushed
the
samples/grpc
branch
2 times, most recently
from
635d4bc to
fc79b30
Compare
BenWhitehead
force-pushed
the
samples/grpc
branch
from
4b68cf2 to
2cd7e83
Compare
product-auto-label
bot
added
size: m
BenWhitehead
force-pushed
the
samples/grpc
branch
from
2cd7e83 to
af8f9cc
Compare
BenWhitehead
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
frankyn
reviewed
May 31, 2023
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java
Outdated
Show resolved
Hide resolved
tritone
reviewed
Jun 1, 2023
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/test/java/com/example/storage/QuickstartGrpcSampleIT.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java
Outdated
Show resolved
Hide resolved
BenWhitehead
force-pushed
the
samples/grpc
branch
from
645e228 to
6d89c3f
Compare
frankyn
reviewed
Jun 2, 2023
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcSample.java
Show resolved
Hide resolved
BenWhitehead
force-pushed
the
samples/grpc
branch
from
cfe6647 to
9f532de
Compare
frankyn
reviewed
Jun 22, 2023
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
LGTM, just one last comment from my side
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java
Show resolved
Hide resolved
tritone
approved these changes
Jun 22, 2023
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
just some comment things, otherwise LGTM
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/storage/QuickstartGrpcDpSample.java
Outdated
Show resolved
Hide resolved
BenWhitehead
changed the title
BenWhitehead
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
BenWhitehead
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.