Skip to content

chore: write chunked text instead of dummy text for pdf chunk #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Mar 1, 2025

write chunked text instead of dummy text for pdf chunk, verified in test env: screen/7YbCgKQH8eWLNHr

@shuoweil shuoweil requested review from GarrettWu and Genesis929 March 1, 2025 00:41
@shuoweil shuoweil requested review from a team as code owners March 1, 2025 00:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 1, 2025
@shuoweil shuoweil enabled auto-merge (squash) March 1, 2025 00:42
@shuoweil shuoweil assigned shuoweil and unassigned rey-esp Mar 1, 2025
@GarrettWu
Copy link
Contributor

Don't use "fix" title, it'll appear in release note. "chore" instead.

@shuoweil shuoweil changed the title fix: write chunked text instead of dummy text for pdf chunk chore: write chunked text instead of dummy text for pdf chunk Mar 1, 2025
@shuoweil shuoweil merged commit 96b0e8a into main Mar 1, 2025
22 of 23 checks passed
@shuoweil shuoweil deleted the shuowei-pdf-chunk-fix-bug-v1 branch March 1, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants