Skip to content

perf: eliminate count queries in llm retry #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

perf: eliminate count queries in llm retry #1489

merged 2 commits into from
Mar 13, 2025

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Mar 12, 2025 •
edited
Loading

screen/Ak8x7ZQBUkL2CPx

@GarrettWu GarrettWu requested review from sycai and jiaxunwu March 12, 2025 22:58
@GarrettWu GarrettWu self-assigned this Mar 12, 2025
@GarrettWu GarrettWu requested review from a team as code owners March 12, 2025 22:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 12, 2025
sycai
sycai approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@sycai sycai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like there are some flakiness in the presubmit. Might need to double check before merging.

@GarrettWu GarrettWu changed the title performance: eliminate count queries in llm retry perf: eliminate count queries in llm retry Mar 13, 2025
@GarrettWu GarrettWu merged commit 1c934c2 into main Mar 13, 2025
23 of 24 checks passed
@GarrettWu GarrettWu deleted the garrettwu-mm-ml branch March 13, 2025 19:32
@release-please release-please bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

@jiaxunwu jiaxunwu Awaiting requested review from jiaxunwu

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettWu @sycai