feat: Add experimental polars execution #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
polars_semi
branch
from
b733f2e to
5449696
Compare
tswast
reviewed
Jun 17, 2025
| requests_transport_adapters: Sequence[ | ||
| Tuple[str, requests.adapters.BaseAdapter] | ||
| ] = (), | ||
| enable_polars_execution: bool = False, |
There was a problem hiding this comment.
Should this be a compute option so it can be changed at runtime?
There was a problem hiding this comment.
Kind of just want to keep it as a constant within-session for now (will need to commit if making this a GA feature though). Turning polars execution on and off mid-session will make things like caching, multi-part execution really tricky
tswast
reviewed
Jun 17, 2025
tswast
previously approved these changes
Jun 25, 2025
| return self._enable_polars_execution | ||
|
|
||
| @enable_polars_execution.setter | ||
| def enable_polars_execution(self, value: bool): |
There was a problem hiding this comment.
Should we add a check that the session has already started? If not (perhaps because we want to safely ignore this if the global session has already started), maybe add a comment for why.
def enable_polars_execution(self, value: bool):
if self._session_started and self._enable_polars_execution != value:
raise ValueError(
SESSION_STARTED_MESSAGE.format(attribute="enable_polars_execution")
)
There was a problem hiding this comment.
yeah, should error out probably, as a session cannot change once started. error added in new revision
TrevorBergeron
force-pushed
the
polars_semi
branch
from
3ee60a0 to
6c6b9b7
Compare
tswast
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕