Skip to content

feat!: add required param 'engine' to multimodal functions #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

GarrettWu
Copy link
Contributor

b/425716056

The breaking change is for preview feature. Not to bump up major version.

Release-As: 2.8.0

@GarrettWu GarrettWu requested review from tswast and shuoweil June 18, 2025 00:07
@GarrettWu GarrettWu self-assigned this Jun 18, 2025
@GarrettWu GarrettWu requested review from a team as code owners June 18, 2025 00:07
@GarrettWu GarrettWu requested a review from glasnt June 18, 2025 00:07
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 18, 2025
shuoweil
shuoweil previously approved these changes Jun 18, 2025
tswast
tswast previously approved these changes Jun 18, 2025
@tswast tswast enabled auto-merge (squash) June 18, 2025 14:20
@tswast
Copy link
Collaborator

tswast commented Jun 18, 2025

@shuoweil Could you take another look? Since I committed aeef2a8 to fix the failing e2e test, it won't let me be an approver I think.

Edit: Actually, it looks like I can approve. Maybe mine was just immediately dismissed because of the owlbot change?

@tswast tswast merged commit 37666e4 into main Jun 18, 2025
18 of 25 checks passed
@tswast tswast deleted the garrettwu-mm-func branch June 18, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants