Skip to content

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jul 18, 2025

Internal issue: 407575751

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Jul 18, 2025
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2025
@sycai
Copy link
Contributor Author

sycai commented Jul 18, 2025

the presubmit failure is about "isdigit":

@pytest.mark.skipif(
        "dev" in pa.__version__,
        # [b/333484335](http://b/333484335) pyarrow is inconsistent on the behavior
        reason="pyarrow dev version is inconsistent on isdigit behavior.",
    )
    def test_isdigit(weird_strings, weird_strings_pd):
        pd_result = weird_strings_pd.str.isdigit()
        bf_result = weird_strings.str.isdigit().to_pandas()
    
>       pd.testing.assert_series_equal(
            bf_result,
            pd_result.astype(pd.BooleanDtype())
            # the dtype here is a case of intentional diversion from pandas
            # see [go/bigframes-dtypes](http://goto.google.com/bigframes-dtypes)
        )

This is not related to this change.

@sycai sycai requested a review from tswast July 18, 2025 17:10
@sycai sycai requested a review from chelsea-lin July 21, 2025 17:09
# Returns a Pandas Series
bf_s.to_pandas()
# [END bigquery_dataframes_convert_bq_dataframe_to_pandas]
assert bf_s.to_pandas is not None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to_pandas()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meticulous!

@sycai sycai requested a review from chelsea-lin July 21, 2025 17:49
@sycai sycai marked this pull request as ready for review July 21, 2025 17:52
@sycai sycai requested review from a team as code owners July 21, 2025 17:52
@sycai sycai requested a review from iennae July 21, 2025 17:52
Copy link

snippet-bot bot commented Jul 21, 2025

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sycai sycai merged commit 6e01cbe into main Jul 21, 2025
19 of 25 checks passed
@sycai sycai deleted the sycai_io_snippets branch July 21, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants