Skip to content

fix: error for object dtype on read_pandas #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2024
Merged

fix: error for object dtype on read_pandas #570

merged 7 commits into from
Apr 10, 2024

Conversation

chelsea-lin
Copy link
Contributor

Fixes internal bug b/329861151🦕

@chelsea-lin chelsea-lin requested a review from tswast April 2, 2024 23:54
@chelsea-lin chelsea-lin requested review from a team as code owners April 2, 2024 23:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 2, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_329861151 branch from 5530229 to 2b7d7d2 Compare April 2, 2024 23:55
TrevorBergeron
TrevorBergeron requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bpd.Series(pd.Series("hello", "world")).to_string() actually works in bigframes. Sometimes we can infer a compatible type from "object" dtype pandas objects.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_329861151 branch 2 times, most recently from 11a17a9 to ebad86c Compare April 10, 2024 16:53
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_329861151 branch from ebad86c to 4b695e6 Compare April 10, 2024 16:54
@chelsea-lin chelsea-lin merged commit 8702dcf into main Apr 10, 2024
16 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_329861151 branch April 10, 2024 20:37
@release-please release-please bot mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chelsea-lin @TrevorBergeron