feat: support bigquery.vector_search()
#736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
ashleyxuu
force-pushed
the
ashleyxu-vector-search
branch
from
02208aa to
c36ba63
Compare
tswast
requested changes
May 31, 2024
tswast
reviewed
Jun 5, 2024
ashleyxuu
force-pushed
the
ashleyxu-vector-search
branch
from
49b65e8 to
72f411f
Compare
tswast
reviewed
Jun 6, 2024
ashleyxuu
force-pushed
the
ashleyxu-vector-search
branch
from
72f411f to
0cfa88a
Compare
tswast
requested changes
Jun 6, 2024
bigframes/bigquery/__init__.py
Outdated
| >>> import bigframes.bigquery as bbq | ||
| >>> bpd.options.display.progress_bar = None | ||
|
|
||
| DataFrame embeddings for which to find nearest neighbors: |
There was a problem hiding this comment.
Let's clarify here that the ARRAY<FLOAT> column is used as the search query.
bigframes/bigquery/__init__.py
Outdated
| <BLANKLINE> | ||
| [4 rows x 4 columns] | ||
|
|
||
| You can specify the name of the column in the query DataFrame embeddings and distance type: |
There was a problem hiding this comment.
Presumably query_column_to_search is required in this case, right? Let's tell the user that if so. Or if not, what happens if they don't specify?
ashleyxuu
force-pushed
the
ashleyxu-vector-search
branch
from
0cfa88a to
f2859f3
Compare
tswast
reviewed
Jun 6, 2024
tswast
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal #344019437 🦕