feat: add PolynomialFeatures to_gbq and pipeline support #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
GarrettWu
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
GarrettWu
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
shobsi
reviewed
Jun 28, 2024
| Tuple[ | ||
| str, | ||
| Union[preprocessing.PreprocessingType, impute.SimpleImputer], | ||
| Union[str, List[str]], | ||
| ] | ||
| ] = [] | ||
| ] = set() |
There was a problem hiding this comment.
what's the reason for going from list to set?
There was a problem hiding this comment.
The processor is different from others. Where previous are 1 -> 1 transform, poly_features is n -> m. So other transformers we get 1 transformed_column, but poly_features we get m transformed_column. Which need to be deduped. And the order of the transformers doesn't matter.
shobsi
approved these changes
Jun 28, 2024
tswast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add
PolynomialFeaturessupport toto_gbqand pipelines (#805)END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕