Skip to content

chore: raise error explicitly for AllOp with windows #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: raise error explicitly for AllOp with windows #2285

wants to merge 2 commits into from

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Nov 20, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 20, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Nov 20, 2025
@chelsea-lin chelsea-lin requested a review from tswast November 20, 2025 21:48
@chelsea-lin chelsea-lin marked this pull request as ready for review November 20, 2025 22:38
@chelsea-lin chelsea-lin requested review from a team as code owners November 20, 2025 22:38
@chelsea-lin chelsea-lin requested a review from shuoweil November 20, 2025 22:38
TrevorBergeron
TrevorBergeron requested changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we doing this?

@chelsea-lin chelsea-lin mentioned this pull request Nov 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@shuoweil shuoweil shuoweil approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Requested changes must be addressed to merge this pull request.

Assignees

@shuoweil shuoweil

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chelsea-lin @tswast @TrevorBergeron @shuoweil