-
Notifications
You must be signed in to change notification settings - Fork 125
fix: add exception context to GenericGBQExceptions #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Thanks, @quoimec ! This LGTM. Any thoughts on how we can unit test this? |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
The
from
keyword adds a__cause__
parameter to the thrown exception. This allows external applications access to the originally thrown exception.My required usecase: my application has experienced BQ rate limiting errors but I am only getting GenericGBQExceptions out the other side, this change will allow me to be more nuanced with my error handling and apply rate limiting pauses only when appropriate.